> On June 6, 2014, 4:31 p.m., Vinod Kone wrote: > > src/tests/allocator_tests.cpp, line 99 > > <https://reviews.apache.org/r/22315/diff/1/?file=604887#file604887line99> > > > > so you are doing this just to get the default principal? > > > > perhaps you can just set it explicitly? you could actually make > > DEFAULT_PRINCIPAL a macro and have DEFAULT_CREDENTIAL use that. > > Jiang Yan Xu wrote: > These are what I found the only places FrameworkInfos are not constructed > from DEFAULT_FRAMEWORK_INFO. I think this is more future proof in that if we > add something to DEFAULT_FRAMEWORK_INFO in the future these don't need to be > updated again unless we want to change the tests. > > Vinod Kone wrote: >
Did you intend to comment here? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22315/#review44979 ----------------------------------------------------------- On June 6, 2014, 1:09 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22315/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 1:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 400764dde2b648c05bd3621af6e992de69c5c7d3 > src/examples/java/TestExceptionFramework.java > 464b3b02e9f4a6d9b8d6f869b363c859ac826498 > src/examples/java/TestFramework.java > 65ee2dc8c4dba2234fe23f4c39c295167d4c5918 > src/examples/java/TestMultipleExecutorsFramework.java > 6846959fe1f12587c28f9380e41332dadf9b273d > src/examples/long_lived_framework.cpp > 638e3162014283c77390e60fdf2a249cead92d63 > src/examples/no_executor_framework.cpp > 0cb987c23db64b781b9e47113b5e2936323cd5bb > src/examples/python/test_framework.py > c37de6ed4b7f3d07ee461123393ed9df7b84155d > src/examples/test_framework.cpp 66ce3a645cedf155516458ab623b442374beaa3a > src/tests/allocator_tests.cpp 79ea09c8d05aa3ac3c035ea3964858bff601e213 > > Diff: https://reviews.apache.org/r/22315/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
