----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22251/#review45329 -----------------------------------------------------------
Patch looks great! Reviews applied: [22251] All tests passed. - Mesos ReviewBot On June 10, 2014, 5:57 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22251/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 5:57 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1417 > https://issues.apache.org/jira/browse/MESOS-1417 > > > Repository: mesos-git > > > Description > ------- > > Give the command executor some cpu and memory. > > This is necessary because after a terminal task status update the slave > updates the container's resources, which would be zero if the executor didn't > have its own resources. > > This does lead to a small overcommit. > > > Diffs > ----- > > src/slave/constants.hpp ace459071d7b1906fe8665878a60ae9edf7d0022 > src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 > > Diff: https://reviews.apache.org/r/22251/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
