> On June 11, 2014, 2:05 a.m., Adam B wrote: > > src/slave/slave.cpp, line 1207 > > <https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1207> > > > > Am I blind? Where does 'executor' come from? You have executorId to > > start with, and it's not until later in this function that "Executor* > > executor = framework->getExecutor(executorId);" > > Maybe you should pass the containerId as a parameter as well, in case > > the executor exited before your containerizer->update() future failed. > > Yifan Gu wrote: > diff 5 is a wrong file... Please forget it. I am sorry.
New diff makes more sense, although maybe you should be checking the future before everything else, like in diff 5? - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review45350 ----------------------------------------------------------- On June 11, 2014, 1:50 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 1:50 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest, CancelTaskIfContainerizerFails > > Which tests that if the containerizer->update() return a Failure, the task > won't be launched and the scheduler will get TASK_LOST. > > make check > > > Thanks, > > Yifan Gu > >
