----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20818/#review45949 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On June 16, 2014, 9:58 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20818/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 9:58 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-759 and MESOS-976 > https://issues.apache.org/jira/browse/MESOS-759 > https://issues.apache.org/jira/browse/MESOS-976 > > > Repository: mesos-git > > > Description > ------- > > internal::Destroyer now uses a single pass of freeze, kill, thaw, reap > to kill all processes in a freezer cgroup. cgroups::destroy will not > complete until all processes have been reaped. A timeout is used for > each step so destroy will eventually fail rather than constantly > retrying. > > Added a test for destroying a freezer cgroup containing a stopped > process. > > > Diffs > ----- > > src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e > src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > eb8933f4e37e09e52123b03890b6df952ceb6ec8 > src/slave/containerizer/linux_launcher.cpp > c17724b138de9d64856fb85db019e52043fbc7af > src/slave/containerizer/mesos_containerizer.cpp > d6df9a1e41024102f3a63cda1b1868b641386172 > src/tests/cgroups_tests.cpp adcf46b1a4071b8f29475d2e20aae6dd8fdf09e7 > > Diff: https://reviews.apache.org/r/20818/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
