----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22689/#review45966 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/22689/#comment81101> use getForkedPidPath() - Vinod Kone On June 17, 2014, 6:37 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22689/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 6:37 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1149 > https://issues.apache.org/jira/browse/MESOS-1149 > > > Repository: mesos-git > > > Description > ------- > > To properly simulate a reboot the executor should be reaped. This must be > done explicitly because the new containerizer + slave won't know about it and > thus the test won't wait until it's been reaped. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 8c6421ba1bb45c32be754ae66d3ba1567c1c65bf > > Diff: https://reviews.apache.org/r/22689/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="SlaveRecovery*Reboot" --gtest_repeat=100 > --gtest_break_on_failure=1 > > > Thanks, > > Ian Downes > >
