> On June 17, 2014, 8:11 p.m., Benjamin Hindman wrote: > > src/common/type_utils.hpp, line 121 > > <https://reviews.apache.org/r/22690/diff/1/?file=611759#file611759line121> > > > > Why not as JSON? > > Vinod Kone wrote: > Seems weird to print JSON for ACLs protobuf when all other protobufs in > this file are printed via debug string? FWIW, protobuf's debug string has > better formatting/readability than our JSON stringify. Once we have JSON > formatter/pprint we could convert all outputstream operators in this file to > use JSON. Thoughts? > > Debug string output: > -------------------- > run_tasks { > principals { > type: ANY > } > users { > values: "guest" > } > } > > JSON stringify > --------------- > > {"permissive":true,"run_tasks":[{"principals":{"type":"ANY"},"users":{"type":"SOME","values":["guest"]}}]} > >
SGTM! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22690/#review45976 ----------------------------------------------------------- On June 17, 2014, 8:37 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22690/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 8:37 p.m.) > > > Review request for mesos, Ben Mahler and Jiang Yan Xu. > > > Bugs: MESOS-1499 > https://issues.apache.org/jira/browse/MESOS-1499 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 3e623cc0137ea4ae9113f9b47a4fc88281ee96c1 > src/authorizer/authorizer.hpp 43e1c3b177c3ea6f4099afbeb0415579b8284cac > src/authorizer/authorizer.cpp c46b31d0f963311e5d646fa16bef51e8ad19c7f2 > src/common/parse.hpp PRE-CREATION > src/common/type_utils.hpp 784a808a5e0b78dab24a4806d6f1f9491a2d6d44 > src/master/flags.hpp 780e219e81e3df57da197784f67deab2b0de4382 > src/tests/master_authorization_tests.cpp > 661d67e50c828b1e5e806f68719aef020455abf2 > src/tests/mesos.cpp 98a7c3895343b1bc84c13e54d12905de3b431338 > > Diff: https://reviews.apache.org/r/22690/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
