----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22722/ -----------------------------------------------------------
Review request for mesos and Ben Mahler. Repository: mesos-git Description ------- Refactor os::user method: * receive an optional uid argument for which the corresponding username will be returned; if no uid id provided, return the username of the current user * change return type to Result<string> * return None() and ErrnoError() on error cases rather then using LOG(FATAL) which ends the application Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 72f3e70ccc189d0a7dd613ccaf79537d3587c49c 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp f6d79b10b7cb0df3e510a3bf6e681726f5f019f3 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 1a6ce0b9a70c0334946e456696b814961e5b4018 src/cli/execute.cpp e881b64807f556b1c1774255beab95d60b6935d6 src/sched/sched.cpp 6e14f1cf78b9518a04c35f856fa2358a3d72ddcf src/scheduler/scheduler.cpp 4ae188e4eba67c630f57863b6c5116162c92a0a1 src/tests/environment.cpp 005fc54759a4be1651f55249e4e8e1bafc2f73ce src/tests/mesos.cpp 98a7c3895343b1bc84c13e54d12905de3b431338 src/tests/script.cpp 9f1be63e2c6538a3ae3fd8f39ad0ea1f66ee88a4 src/tests/slave_tests.cpp aaf509d1e0798928ab729704a42ec5aed18c11a2 Diff: https://reviews.apache.org/r/22722/diff/ Testing ------- Thanks, Alexandra Sava
