----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46111 -----------------------------------------------------------
src/launcher/main.cpp <https://reviews.apache.org/r/21594/#comment81287> FYI, we will do a refactor on the launcher/Operation interfaces per discussion with BenH. We will need to create a separate binary (e.g., mesos-network-utils) to launcher the 'Update' operation. Also, we might wanna add some more operations to mesos-network-utils like cleanup the hosts (removing ingress qdisc on eth0 and lo and remove all veths) to ease the cleanup of a host. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/21594/#comment81280> Probably adjust the comments here. In theory, should should be able to support an arbitrary positive size, right? Say that this is for performance and debugability concern. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/21594/#comment81283> return Error( "The number of ephemeral ports for each container (" + stringify(flags.per_container_ephemeral_port_size) + ") is not a power of 2"); src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/21594/#comment81285> I don't like splitting into 'configureNetwork': 1) it's functionality is not atomic and it's not clear what does this function do from its name 2) it's not used anywhere else 3) people needs to jump while reading the code - Jie Yu On June 18, 2014, 1:16 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21594/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 1:16 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1324 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1324 > > > Repository: mesos-git > > > Description > ------- > > Added a network isolator using port-range based traffic redirection on Linux. > > - Containers are assigned non-ephemeral ports by the scheduler and ephemeral > ports by the network isolator. > - Virtual ethernet devices and Traffic Control filters are set up so that > network traffic in and out of the containers is isolated based on the ports > assigned to them. > - Containers run inside their own network namespaces with separate network > stacks, from which per-container network statistics can be retrieved. > > A joint work with: > - Cong Wang ([email protected]) > - Jie Yu ([email protected]) > - Ian Downes ([email protected]) > > > Diffs > ----- > > include/mesos/mesos.proto 2f6be05 > src/Makefile.am b1b7d2d > src/launcher/main.cpp b497e98 > src/slave/constants.hpp c65a62d > src/slave/constants.cpp 51f65bb > src/slave/containerizer/isolators/network/port_mapping.hpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp 85c74f0 > src/slave/containerizer/mesos_containerizer.cpp 4d97d49 > src/slave/flags.hpp 3b8ba08 > src/slave/main.cpp 8c2b70c > src/tests/environment.cpp 005fc54 > src/tests/mesos.cpp f197da6 > > Diff: https://reviews.apache.org/r/21594/diff/ > > > Testing > ------- > > make check on linux. more test cases are being written. > > > Thanks, > > Chi Zhang > >
