----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22754/#review46181 -----------------------------------------------------------
Patch looks great! Reviews applied: [22754] All tests passed. - Mesos ReviewBot On June 18, 2014, 8:51 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22754/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 8:51 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > This is the first part of the 'deactivate slave' mechanism. > > This part consists in creating an HTTP endpoint which receives HTTP posts > from operators. Each post contains a JSON object with a list of slave ids > that will further be deactivated by the master. > > NOTE: For now, I created a dummy method in the Master class > (deactivateSlaves) which just prints the ids of the slaves that will be > deactivated. This method should be further improved in order to really > deactivate them. > Also, I will create a similar endpoint for reactivating slaves, but this will > be in a separate review. > > > Diffs > ----- > > src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123 > src/master/master.hpp 2844446e2674df6e11f4c2915ed324fcc103532c > src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 > > Diff: https://reviews.apache.org/r/22754/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
