----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22852/#review46563 -----------------------------------------------------------
lgtm modulo comments. i'll let @iandownes shepherd this to completion. src/slave/containerizer/launcher.hpp <https://reviews.apache.org/r/22852/#comment82000> From here, it's not clear to me when 'setup' will be called if you are forking the binary at 'path'. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/22852/#comment82009> Can setsid() be part of the 'setup'? src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/22852/#comment82012> Is it safe to call this in a subprocess? src/slave/containerizer/mesos_containerizer.hpp <https://reviews.apache.org/r/22852/#comment82013> why snakecase? src/slave/containerizer/mesos_containerizer.hpp <https://reviews.apache.org/r/22852/#comment82015> s/preparations/commands/ src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/22852/#comment82014> s/preparations/commands/ - Vinod Kone On June 21, 2014, 4:57 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22852/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 4:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1404 > https://issues.apache.org/jira/browse/MESOS-1404 > > > Repository: mesos-git > > > Description > ------- > > See summary. The main idea is to create a new binary called > 'mesos-containerizer-helper' which performs most of the logic of 'execute' in > the original code. > > Also, we leverage the new Subprocess interface to handle redirections. > > (BTW: I fixed a few 70 char width comments issue when I doing the refactor). > > > Diffs > ----- > > src/Makefile.am fd2c80f > src/slave/containerizer/launcher.hpp 63c0cb6 > src/slave/containerizer/launcher.cpp c43396a > src/slave/containerizer/linux_launcher.hpp 60b401f > src/slave/containerizer/linux_launcher.cpp 85c74f0 > src/slave/containerizer/mesos_containerizer.hpp 1f5908a > src/slave/containerizer/mesos_containerizer.cpp 61c0a8d > src/slave/containerizer/mesos_containerizer_helper.cpp PRE-CREATION > src/tests/isolator_tests.cpp 0bbec09 > > Diff: https://reviews.apache.org/r/22852/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
