> On June 24, 2014, 7:42 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1945 > > <https://reviews.apache.org/r/21594/diff/7/?file=616163#file616163line1945> > > > > Instead of scripts can we use the new Subcommand abstraction here?
I think for ::prepare, mesos_containerizer collects all the preparation scripts and run them with a launch of mesoscontainerizelaunch, which is a subcommand. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21594/#review46568 ----------------------------------------------------------- On June 24, 2014, 10:03 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21594/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 10:03 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1324 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1324 > > > Repository: mesos-git > > > Description > ------- > > Added a network isolator using port-range based traffic redirection on Linux. > > - Containers are assigned non-ephemeral ports by the scheduler and ephemeral > ports by the network isolator. > - Virtual ethernet devices and Traffic Control filters are set up so that > network traffic in and out of the containers is isolated based on the ports > assigned to them. > - Containers run inside their own network namespaces with separate network > stacks, from which per-container network statistics can be retrieved. > > A joint work with: > - Cong Wang (cw...@twopensource.com) > - Jie Yu (yujie....@gmail.com) > - Ian Downes (ian.dow...@gmail.com) > > > Diffs > ----- > > include/mesos/mesos.proto 2f6be05 > src/Makefile.am a87eb21 > src/slave/constants.hpp c65a62d > src/slave/constants.cpp 51f65bb > src/slave/containerizer/isolators/network/helper.cpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.hpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp 85c74f0 > src/slave/containerizer/mesos_containerizer.cpp 61c0a8d > src/slave/flags.hpp 3b8ba08 > src/tests/environment.cpp 21b9d1d > src/tests/isolator_tests.cpp 0bbec09 > src/tests/mesos.cpp 1037420 > > Diff: https://reviews.apache.org/r/21594/diff/ > > > Testing > ------- > > make check on linux. more test cases are being written. > > > Thanks, > > Chi Zhang > >
