----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22471/#review46771 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82346> Only some tests depend on nameservers. Do the ASSERT in those tests. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82347> Could these be setup by the operators on the host irrespective of the test? If yes, removing them seems dangerous? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82348> s/remove/removing/ src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22471/#comment82349> Instead of making this a member variable, just pass them to the launchHelper. - Vinod Kone On June 26, 2014, 6:03 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22471/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 6:03 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > These tests test different different protocols (TCP, UDP, ICMP, ARP, DNS) in > different connection scenarios (C2C, H2C). > > > Diffs > ----- > > src/tests/isolator_tests.cpp 6fef4e0 > > Diff: https://reviews.apache.org/r/22471/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Chi Zhang > >
