----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22825/#review46831 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/22825/#comment82399> nit: s/Optinally/Optionally/ 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/22825/#comment82400> why not just: if (n.isSome() && tokens.size() == n.get()) { break; } and remove _n and some. 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/22825/#comment82401> the option to ignore empty tokens might be useful for the future. maybe a TODO. - Dominic Hamon On June 26, 2014, 10:49 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22825/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 10:49 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1522 > https://issues.apache.org/jira/browse/MESOS-1522 > > > Repository: mesos-git > > > Description > ------- > > SplitN function is stout/strings so we can choose how many tokens we want to > retreive > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 08428b8 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp c83156e > > Diff: https://reviews.apache.org/r/22825/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >