> On July 1, 2014, 5:03 p.m., Benjamin Hindman wrote: > > configure.ac, line 380 > > <https://reviews.apache.org/r/23203/diff/1/?file=621393#file621393line380> > > > > Are you sure that this is still necessary after > > https://github.com/apache/mesos/commit/294337466ccdbbc933c17712d9ca6877def3f83e? > > > > I think it would be nice to make what I did even more explicit though > > (right now it works because the Python checks are below the clang checks).
Nope, not necessary at all. My bad! Thanks for the heads up =) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23203/#review47096 ----------------------------------------------------------- On July 1, 2014, 4:54 p.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23203/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 4:54 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1468 > https://issues.apache.org/jira/browse/MESOS-1468 > > > Repository: mesos-git > > > Description > ------- > > Fixed building of python egg on osx. > > > Diffs > ----- > > configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d > > Diff: https://reviews.apache.org/r/23203/diff/ > > > Testing > ------- > > Successfully built the python egg on OSX. > > > Thanks, > > Thomas Rampelberg > >
