----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23220/#review47233 -----------------------------------------------------------
Patch looks great! Reviews applied: [23220] All tests passed. - Mesos ReviewBot On July 2, 2014, 12:49 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23220/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 12:49 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-1536 > https://issues.apache.org/jira/browse/MESOS-1536 > > > Repository: mesos-git > > > Description > ------- > > These tests don't need ZK. It unnecessarily slows these tests down and also > makes it hard to finely control the timing of slave/framework > re-registrations. So I made them AllocatorTests. > > Also, fixed the timing issue described in the bug. > > > Diffs > ----- > > src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc > src/tests/allocator_tests.cpp 42cb3455a82090ce85fe6dd4382146bcdb17f651 > src/tests/allocator_zookeeper_tests.cpp > 091fb08f712104c721da0935f0600972f6d2bc71 > > Diff: https://reviews.apache.org/r/23220/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
