> On July 3, 2014, 2:01 p.m., Vinod Kone wrote: > > src/examples/load_generator_framework.cpp, lines 60-86 > > <https://reviews.apache.org/r/23250/diff/3/?file=623764#file623764line60> > > > > I don't think you want to block in initialize(). dispatch to another > > method (generate()?) that does the actual work.
Fine. But initialize() should be fine I think. It's executed by ProcessManager::resume() in the same way events are executed. But perhaps moving it over to generate() makes the logic more clear. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23250/#review47321 ----------------------------------------------------------- On July 3, 2014, 1:50 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23250/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 1:50 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1530 > https://issues.apache.org/jira/browse/MESOS-1530 > > > Repository: mesos-git > > > Description > ------- > > The binary is called "mesos-load-generator-framework" and it's installed into > {prefix}/bin/mesos-load-generator-framework so it can be distributed and run > as a continuous test where Mesos is deployed. > I am open to suggestions. > > > Diffs > ----- > > src/Makefile.am 64389391e04d12f09737ff56a1cc88c4543e63ad > src/examples/load_generator_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23250/diff/ > > > Testing > ------- > > Used the binary in distributed tests. > > > Thanks, > > Jiang Yan Xu > >
