> On July 3, 2014, 12:18 a.m., Vinod Kone wrote: > > src/tests/port_mapping_tests.cpp, line 1233 > > <https://reviews.apache.org/r/23214/diff/2/?file=623164#file623164line1233> > > > > can you use ASSERT_NE? > > > > Also, how is this possible? Aren't we controlling whether this > > isolation is set or not? > > Chi Zhang wrote: > flags.isolation is set in > ContainerizerTest<slave::MesosContainerizer>::CreateSlaveFlags. > network/portmapping could be dropped if certain checks don't meet. > > Vinod Kone wrote: > That seems dangerous. Should these tests be even running if those checks > (non-linux, non-root, non-network-isolator-configuration) are not met? > > You might want to update environment.cpp and this file to make these > tests are not run in the first place.
kept the isolation setting part in MesosTest since slave recovery tests need it. added a check in environment::enable to disable PortMappingIsolatorTest and PortMappingMesosTest kept the ASSERT_NE(it, isolations.end()) check since I call ::erase on it anyway right after. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23214/#review47258 ----------------------------------------------------------- On July 3, 2014, 9:27 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23214/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 9:27 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1557 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1557 > > > Repository: mesos-git > > > Description > ------- > > This eases deployment where a slave could be upgraded to use Network Isolator > without removing all the existing tasks. > > - Added a new test. > - Moved all portmapping tests to a new file. > > > Diffs > ----- > > src/Makefile.am 6438939 > src/slave/containerizer/isolators/network/port_mapping.hpp ac3bee3 > src/slave/containerizer/isolators/network/port_mapping.cpp d16547a > src/tests/environment.cpp 4aaf1a4 > src/tests/isolator_tests.cpp 4650f97 > src/tests/mesos.cpp 0d7f335 > src/tests/port_mapping_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23214/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
