----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23416/#review47695 -----------------------------------------------------------
Ship it! Do your disabled "flaky" tests pass for you when you enable them after this change? src/health-check/main.cpp <https://reviews.apache.org/r/23416/#comment83850> We usually put the '+' at the end of the line, not the start of the next line. - Adam B On July 11, 2014, 1:46 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23416/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 1:46 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-1577 > https://issues.apache.org/jira/browse/MESOS-1577 > > > Repository: mesos-git > > > Description > ------- > > Fix health check command subprocess handling. > > Currently it doesn't check all subprocess future states, and also creates a > pipe to stdin which can cause some scripts to expect stdin input and blocks. > > > Diffs > ----- > > src/health-check/main.cpp 707810a > > Diff: https://reviews.apache.org/r/23416/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
