----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216/#review47758 -----------------------------------------------------------
Ship it! Looks great! LGTM. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment83969> This fits in one line? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment83970> Move this line into the lock/unlock block. - Jie Yu On July 15, 2014, 12:11 a.m., Zuyu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23216/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 12:11 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod > Kone. > > > Repository: mesos-git > > > Description > ------- > > Added the low level scheduler example using pthread. > > > Diffs > ----- > > src/Makefile.am 2c7bfc57103c47523466c297f2596eaf4eb55c3c > src/examples/low_level_scheduler_pthread.cpp PRE-CREATION > src/tests/examples_tests.cpp 2b554d72f0058a68f589719373f3d3e37a3a7ba3 > src/tests/low_level_scheduler_pthread_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/23216/diff/ > > > Testing > ------- > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from ExamplesTest > [ RUN ] ExamplesTest.LowLevelSchedulerPthread > [ OK ] ExamplesTest.LowLevelSchedulerPthread (1655 ms) > [----------] 1 test from ExamplesTest (1655 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1669 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Zuyu Zhang > >