----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/#review47862 -----------------------------------------------------------
LGTM, but I'll let BenH give his final word since he's already had some comments. Also, I'm still not convinced we need to change all the EXPECTs to ASSERTs. While an ASSERT will fail the test/function faster, it may also skip cleanup code causing a leak. - Adam B On July 15, 2014, 1:34 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23443/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 1:34 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-1533 > https://issues.apache.org/jira/browse/MESOS-1533 > > > Repository: mesos-git > > > Description > ------- > > Currently the health check tests are disabled as it was flaky. Part of the > reason is that all assertions was EXPECTs instead of ASSERTs so it will > continue to execute. > Another issue was it's currently discovering the path to launch health check > executable from the command executor main argv[0] path. > However, the correct path is to launch the generated script that does library > path resolution, which is the parent of .libs. > > > Diffs > ----- > > src/launcher/executor.cpp a573637 > src/tests/health_check_tests.cpp 44711fd > > Diff: https://reviews.apache.org/r/23443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
