----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23453/#review48324 -----------------------------------------------------------
Can you test this with a non-standard glog location to suss out any unforeseen issues? configure.ac <https://reviews.apache.org/r/23453/#comment84811> Did you miss checking the library like you did for leveldb? More importantly, don't you have to set LDFLAGS so that "-lglog" works below? - Vinod Kone On July 18, 2014, 8:52 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23453/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 8:52 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1170 > https://issues.apache.org/jira/browse/MESOS-1170 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against the system installed version of glog. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 705d19c > 3rdparty/libprocess/Makefile.am 583f6ef > 3rdparty/libprocess/configure.ac 3a38b04 > configure.ac e747208 > src/Makefile.am c216e2f > src/python/setup.py.in b996dfe > > Diff: https://reviews.apache.org/r/23453/diff/ > > > Testing > ------- > > configure --disable-bundled && make check > configure && make check > > I did not test a full prefix install, but I relied on the previously defined > semantics. > > > Thanks, > > Timothy St. Clair > >