> On July 24, 2014, 12:22 a.m., Jiang Yan Xu wrote: > > future.hpp already has set/fail/discard on some collection of futures, > > maybe we can add these methods for promises there as well?
Thanks for bringing that up, there is only the following in future.hpp: fail(promises) // fail a collection of promises (unused) discard(futures) // invoke discard a collection of futures, does not transition the future (used) Rather than pile on to these, I've added a TODO in this review and removed the fail utility in https://reviews.apache.org/r/23874/ since it was unused. Later we can introduce a nice futures namespace in libprocess or mesos per benh's TODO. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23866/#review48586 ----------------------------------------------------------- On July 23, 2014, 11:18 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23866/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 11:18 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > I added some helpers to remove the redundant set operations and included the > definitions of StandaloneMasterDetectorProcess alongside the declarations > since it's a trivial class. > > > Diffs > ----- > > src/master/detector.cpp a34cc211941972e2d64802d5c7ed3f5026229744 > > Diff: https://reviews.apache.org/r/23866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
