----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review48480 -----------------------------------------------------------
Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still create sub modules and an "empty" metapackage? Or at that point would we just put everything inside of the 'mesos' module (including the protobufs). Given that we'll be killing the native component in due time I don't want us to do something that is specific to that now. Makefile.am <https://reviews.apache.org/r/23224/#comment85119> Can you kill the whitespace? src/Makefile.am <https://reviews.apache.org/r/23224/#comment85376> Kill whitespace please. src/Makefile.am <https://reviews.apache.org/r/23224/#comment85377> Weird indenting here? -1 space maybe? src/Makefile.am <https://reviews.apache.org/r/23224/#comment85378> Doesn't this delete the setup.py that got generated by configure? src/Makefile.am <https://reviews.apache.org/r/23224/#comment85379> Does this only delete stuff in the 'python' directory? Or throughout all of 'src'? src/examples/python/test-framework.in <https://reviews.apache.org/r/23224/#comment85380> Every time I see this in this review without a : between PROTOBUF_EGG and MESOS_EGGS it seems like a bug and I have to remind myself that above in the code you prefixed MESOS_EGGS with :, any reason not to use : in the suffix and then force the : between PROTOBUF_EGG and MESOS_EGGS so people don't have to go back and look at code to confirm this is correct? src/python/native/setup.py.in <https://reviews.apache.org/r/23224/#comment85382> Why import this versus keeping this inline in one file? src/python/setup.py.in <https://reviews.apache.org/r/23224/#comment85381> Let's use [email protected] (here and everywhere else too). - Benjamin Hindman On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23224/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 5:58 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-857 > https://issues.apache.org/jira/browse/MESOS-857 > > > Repository: mesos-git > > > Description > ------- > > The existing module has been split into three separate ones: > > - mesos.api - This contains the stub implementations for the > Executor/Scheduler > - mesos.native - The old _mesos module. > - mesos.protocol - All protobufs. > > There is also a base metapackage `mesos` that allows a potential `pip install > mesos` to correctly install everything required. While mesos.api and > mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not > changed and will need some more work first. > > > Diffs > ----- > > Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f > configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d > mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 > mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 > src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 > src/examples/python/test-containerizer.in > 569519b3b9755959f9bf931d3c81be9a00b64bc9 > src/examples/python/test-executor.in > 7e8875f0fd74dc9f9207986864edbce588ec3fb8 > src/examples/python/test-framework.in > c4683b97b87ba8753e842b0c75cc3d65140a5cf7 > src/examples/python/test_containerizer.py > c65d891539bcee775741626596997afe8471c930 > src/examples/python/test_executor.py > 065b50a6146cb39a82024d82c20cf89f940a9e57 > src/examples/python/test_framework.py > fce090fe542e3863770d7daea3d8764da1d8d5df > src/python/api/setup.py.in PRE-CREATION > src/python/api/src/mesos/__init__.py PRE-CREATION > src/python/native/ext_def.py.in PRE-CREATION > src/python/native/mesos_executor_driver_impl.hpp > src/python/native/mesos_executor_driver_impl.cpp > src/python/native/mesos_scheduler_driver_impl.hpp > src/python/native/mesos_scheduler_driver_impl.cpp > src/python/native/module.hpp > src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 > src/python/native/proxy_executor.hpp > src/python/native/proxy_executor.cpp > src/python/native/proxy_scheduler.hpp > src/python/native/proxy_scheduler.cpp > src/python/native/setup.py.in PRE-CREATION > src/python/native/src/mesos/__init__.py PRE-CREATION > src/python/native/src/mesos/native/__init__.py PRE-CREATION > src/python/protocol/setup.py.in PRE-CREATION > src/python/protocol/src/mesos/__init__.py PRE-CREATION > src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION > src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d > src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 > src/python/src/mesos/__init__.py PRE-CREATION > > Diff: https://reviews.apache.org/r/23224/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Rampelberg > >
