----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23874/#review48662 -----------------------------------------------------------
You are right that it would be inconvenient if the caller still needs to loop through the collection to delete the promises. Do you think it should be in a file other than future.hpp? Maybe futures.hpp? Should be select(futures) be moved there too? Anyway, it feels strange to leave discard(futures) behind. I agree that we don't need to deal with this right now so maybe this can be done together later (without removing fail(futures) now)? - Jiang Yan Xu On July 23, 2014, 7:55 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23874/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 7:55 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > The fail() utility is present in the mesos code as well, but usually involves > deleting the promises and clearing the container. > > This version inside future.hpp is unused. It would be best to remove it in > favor of exposing more useful utilities in libprocess or mesos. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 5b0ed9b6fdb7e1a4b3250509ee83eb057e3696e5 > > Diff: https://reviews.apache.org/r/23874/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
