----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23954/#review48788 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/23954/#comment85532> s/it is/they are/ src/slave/slave.cpp <https://reviews.apache.org/r/23954/#comment85533> Is it worth adding a warning message here that the private resources are being ignored? - Ian Downes On July 25, 2014, 4:07 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23954/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 4:07 p.m.) > > > Review request for mesos, Ben Mahler and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. That's gonna prevent the slave from flapping if someone set the > private resources but does not want to use the network isolator. > > > Diffs > ----- > > src/slave/slave.cpp 1d56918 > > Diff: https://reviews.apache.org/r/23954/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
