----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20499/#review48909 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20499/#comment85687> Isn't this a change of behavior? Before, if an error occurred we considered it to be an empty listing. Now, the program will crash by calling .get() on an Try<>::error. Ditto for the changes below. - Ben Mahler On July 28, 2014, 7:59 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20499/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 7:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1237 > https://issues.apache.org/jira/browse/MESOS-1237 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 08251724fbe45431db2c3637c6beec81f5744c4c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp > e916f027e1c9918ec4f2d41e03926c10a1080bca > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > c5509632988401ee96ed2471c7278c8e164800d7 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 7fa7346346a33a05fbcd30a11053948eedba4764 > > Diff: https://reviews.apache.org/r/20499/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
