----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20494/#review48912 -----------------------------------------------------------
Ship it! Looks good, just a few logging cleanups below. src/launcher/fetcher.cpp <https://reviews.apache.org/r/20494/#comment85692> s/chmodded/chmod/ src/launcher/fetcher.cpp <https://reviews.apache.org/r/20494/#comment85691> I think you want to keep the messaging as it was: EXIT(1) << "Failed to chmod: " << chmod.get(); Given my comments on: https://reviews.apache.org/r/20493/ src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/20494/#comment85694> Not yours, but can you add single quotes around the work directory path? src/slave/containerizer/mesos/launch.cpp <https://reviews.apache.org/r/20494/#comment85695> Not yours but single quotes around the user name might be nice? - Ben Mahler On July 28, 2014, 7:58 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20494/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 7:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1236 > https://issues.apache.org/jira/browse/MESOS-1236 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 > src/slave/containerizer/mesos/launch.cpp > 2db1c7a16905ea24435fd33a4037f69697755813 > src/tests/log_tests.cpp b60577d8ee43a4ae94357139e8dfad9eac67a83a > src/tests/script.cpp 15a6542e5d24e3983f920918b0ab62d35c458411 > src/tests/utils.cpp 05ef3058b6a1e1daa16351787831687342462eba > > Diff: https://reviews.apache.org/r/20494/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
