-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/#review48925
-----------------------------------------------------------



support/timed_tests.sh
<https://reviews.apache.org/r/23700/#comment85715>

    this might be simplified:
    
    MAKE='make' GTEST_FILTER='Master*' timed_tests.sh 3600
    
    ie - we assume we're running:
    
    ${MAKE} GTEST_FILTER=''
    ${MAKE} check GTEST_FILTER=${GTEST_FILTER}
    
    then the user can override the make flags and the tests run, but the 
default just does the right thing.



support/timed_tests.sh
<https://reviews.apache.org/r/23700/#comment85716>

    nit: s/runnning/running/


- Dominic Hamon


On July 28, 2014, 3:53 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23700/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 3:53 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon and Jie Yu.
> 
> 
> Bugs: MESOS-1559
>     https://issues.apache.org/jira/browse/MESOS-1559
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Example usage:
> 
> ./support/timed_tests.sh -m "make check GTEST_FILTER=" "MESOS_VERBOSE=1 make 
> check GTEST_SHUFFLE=1" $((120 * 60))
> 
> # Bypass the 'make' stage.
> ./support/timed_tests.sh "MESOS_VERBOSE=1 make check GTEST_SHUFFLE=1" 3600
> 
> It works by setting a new sid for the test script so that all subprocesses 
> are in this new session.
> 
> 
> Diffs
> -----
> 
>   support/timed_tests.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23700/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux with and without Jenkins.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to