> On July 25, 2014, 11:54 p.m., Ian Downes wrote: > > src/tests/port_mapping_tests.cpp, line 125 > > <https://reviews.apache.org/r/23955/diff/1/?file=642538#file642538line125> > > > > MNT_DETACH makes it a lazy unmount - how do you know the mount has > > actually been unmounted by the time you attempt the rm?
See my added comments. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23955/#review48790 ----------------------------------------------------------- On July 28, 2014, 11:59 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23955/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 11:59 p.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20 > src/tests/port_mapping_tests.cpp f1de157 > > Diff: https://reviews.apache.org/r/23955/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
