----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review49316 -----------------------------------------------------------
Patch looks great! Reviews applied: [23224] All tests passed. - Mesos ReviewBot On Aug. 1, 2014, 1:39 a.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23224/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 1:39 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-857 > https://issues.apache.org/jira/browse/MESOS-857 > > > Repository: mesos-git > > > Description > ------- > > The existing module has been split into two separate ones: > > - mesos.interface - This contains the stub implementations for the > Executor/Scheduler as well as the protobufs. > - mesos.native - The old _mesos module. > > There is also a base metapackage `mesos` that allows a potential `pip install > mesos` to correctly install everything required. While mesos.interface can > now be uploaded to the cheeseshop, mesos.native has not changed and will need > some more work first. > > > > Diffs > ----- > > Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f > configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d > docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b > mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 > mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 > src/Makefile.am b660d912c92594ef679b71caf508134f20511dae > src/examples/python/test-containerizer.in > 569519b3b9755959f9bf931d3c81be9a00b64bc9 > src/examples/python/test-executor.in > 7e8875f0fd74dc9f9207986864edbce588ec3fb8 > src/examples/python/test-framework.in > c4683b97b87ba8753e842b0c75cc3d65140a5cf7 > src/examples/python/test_containerizer.py > c65d891539bcee775741626596997afe8471c930 > src/examples/python/test_executor.py > 065b50a6146cb39a82024d82c20cf89f940a9e57 > src/examples/python/test_framework.py > fce090fe542e3863770d7daea3d8764da1d8d5df > src/python/interface/setup.py.in PRE-CREATION > src/python/interface/src/mesos/__init__.py PRE-CREATION > src/python/native/ext_modules.py.in PRE-CREATION > src/python/native/mesos_executor_driver_impl.hpp > src/python/native/mesos_executor_driver_impl.cpp > src/python/native/mesos_scheduler_driver_impl.hpp > src/python/native/mesos_scheduler_driver_impl.cpp > src/python/native/module.hpp > src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc > src/python/native/proxy_executor.hpp > src/python/native/proxy_executor.cpp > src/python/native/proxy_scheduler.hpp > src/python/native/proxy_scheduler.cpp > src/python/native/setup.py.in PRE-CREATION > src/python/native/src/mesos/__init__.py PRE-CREATION > src/python/native/src/mesos/native/__init__.py PRE-CREATION > src/python/protocol/setup.py.in PRE-CREATION > src/python/protocol/src/mesos/__init__.py PRE-CREATION > src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION > src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a > src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 > src/python/src/mesos/__init__.py PRE-CREATION > > Diff: https://reviews.apache.org/r/23224/diff/ > > > Testing > ------- > > - `make distcheck -j6` (note that this runs the actual python framework tests) > - `import mesos.native` > - `python setup.py sdist bdist_egg register upload` && `pip install > mesos.interface` > > > Thanks, > > Thomas Rampelberg > >