----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23868/ -----------------------------------------------------------
(Updated Aug. 4, 2014, 7:25 p.m.) Review request for mesos, Vinod Kone and Jiang Yan Xu. Changes ------- Avoid an unnecessary re-detection when a ping arrives in-between the timer firing and being processed by the slave: (1) Timer T fires, (2) Slave::ping (3) Slave::pingTimeout due to Timer T. Rebased. Bugs: MESOS-1529 https://issues.apache.org/jira/browse/MESOS-1529 Repository: mesos-git Description ------- This is the first step in MESOS-1529. If we get into a situation where the slave thinks it is registered, but the master does not, then the slave should re-register. This situation can be often be detected on the slave side when the slave is no longer receiving pings from the master. Diffs (updated) ----- src/master/constants.hpp 3b4d68b2e68e3e7b30a9e717b15172776671c375 src/slave/constants.hpp 97dc1b30fa81000ea60223c4059a0a64d27e91c4 src/slave/constants.cpp a75b1ef8eddeb55350810b36ac35136d2e5d6f9d src/slave/slave.hpp 9ef597ede18f99a8580c88002741b9da7e3da6f4 src/slave/slave.cpp df69b75f2eae31d61918f2a2d0d074ea3daba083 src/tests/slave_tests.cpp b4f9f3091dad7dbf325ca502a1d6de06b751a471 Diff: https://reviews.apache.org/r/23868/diff/ Testing ------- Added tests. Thanks, Ben Mahler