----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24128/#review49620 -----------------------------------------------------------
src/master/allocator.hpp <https://reviews.apache.org/r/24128/#comment86845> Seems that having a default in a virtual function is dangerous. Refer to this thread: http://stackoverflow.com/questions/3533589/can-virtual-functions-have-default-parameters I prefer removing the default (just like we did for resourcesUnused). I understand that it means a lot of changes to the tests and code. src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/24128/#comment86856> What if seconds == Duration::zero()? Probably you should just copy the logic from above. src/master/master.cpp <https://reviews.apache.org/r/24128/#comment86857> Remove the tailing period. - Jie Yu On Aug. 4, 2014, 9:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24128/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 9:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1666 > https://issues.apache.org/jira/browse/MESOS-1666 > > > Repository: mesos-git > > > Description > ------- > > when network isolation is enabled, we should keep track of how many executors > have launched on a given host to avoid sending offers for those that have hit > the container limit. > > this is a short-term fix for the issue to enable broader testing of network > monitoring and isolation. > > > Diffs > ----- > > docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa > src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938 > src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6 > src/master/hierarchical_allocator_process.hpp > 35d1579bbd665dfdd238932902ae16880dadeb66 > src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459 > src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 > src/tests/master_tests.cpp 5a1cf7f1f7a4864f516825cc14504c870b60055e > src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a > src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05 > > Diff: https://reviews.apache.org/r/24128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
