----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24339/#review49638 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/24339/#comment86888> it might be worth a method to calculate this so it isn't repeated everywhere. Duration masterPingTimeout() { return master::SLAVE_PING_TIMEOUT * master::MAX_SLAVE_PING_TIMEOUTS; } - Dominic Hamon On Aug. 5, 2014, 1:48 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24339/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 1:48 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1673 > https://issues.apache.org/jira/browse/MESOS-1673 > > > Repository: mesos-git > > > Description > ------- > > See summary and ticket. > > > Diffs > ----- > > src/slave/constants.hpp bc16fe5 > src/slave/constants.cpp f00300d > src/slave/slave.cpp ef921e1 > src/tests/slave_tests.cpp 432d8a2 > > Diff: https://reviews.apache.org/r/24339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
