----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24252/#review49738 -----------------------------------------------------------
Ship it! Seems fine. We should probably open a ticket to add '-version-info 0:0:0' going forwards. - Timothy St. Clair On Aug. 4, 2014, 7:33 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24252/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy St. Clair. > > > Bugs: MESOS-1633 > https://issues.apache.org/jira/browse/MESOS-1633 > > > Repository: mesos-git > > > Description > ------- > > By default, we now build both static and dynamic libraries. For > operators/package mantainers that do not want a static library included in > their distribution "--disable-static" configure flag can be provided. > > This is consistent with how some other packages do it (e.g, libev, glog, > gmock). > > > Diffs > ----- > > src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 > > Diff: https://reviews.apache.org/r/24252/diff/ > > > Testing > ------- > > ./configure --> builds both static and dynamic mesos libs > ./configure --disable-static --> builds only dynamic mesos lib > > ./configure --disable-shared has a build error, but AFAICT it is irrelevant > to this change. I'll open separate ticket for that. > > > Thanks, > > Vinod Kone > >
