> On Aug. 6, 2014, 3:53 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 3466 > > <https://reviews.apache.org/r/24286/diff/3/?file=653362#file653362line3466> > > > > I think we've been trying to name these with the _ as a suffix, akin to > > prime notation: offer'
Done. > On Aug. 6, 2014, 3:53 a.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2016-2017 > > <https://reviews.apache.org/r/24286/diff/3/?file=653363#file653363line2016> > > > > Do you need these two? Or can you use the StartSlave() that only takes > > the flags? > > > > At which point the comment on the last line probably isn't relevant? > > > > Shutdown(); // Must shutdown before 'containerizer' gets deallocated. Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24286/#review49691 ----------------------------------------------------------- On Aug. 6, 2014, 2:31 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24286/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 2:31 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1654 > https://issues.apache.org/jira/browse/MESOS-1654 > > > Repository: mesos-git > > > Description > ------- > > Introduced an optional flag 'visible' for resource. Invisible resources are > not exposed to the framework. The idea is that the master will perform > allocation for those resources. > > > Diffs > ----- > > src/master/master.cpp 9bede96 > src/tests/master_tests.cpp 9a1a373 > > Diff: https://reviews.apache.org/r/24286/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
