----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24270/#review49857 -----------------------------------------------------------
Patch looks great! Reviews applied: [24270] All tests passed. - Mesos ReviewBot On Aug. 5, 2014, 11:33 p.m., Craig Hansen-Sturm wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24270/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 11:33 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1669 > https://issues.apache.org/jira/browse/MESOS-1669 > > > Repository: mesos-git > > > Description > ------- > > New test added which serves as a performance test for reaping. This test > forks N children (default value is 4), kills these children, and then uses > process::collect to collect all status results. This is a simple > generalization of the existing ChildProcess test, except that it is realtime > (as required for profiling), e.g., no clock manipulation is performed. This > test is also useful for stressing the collect.hpp interfaces. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c > > Diff: https://reviews.apache.org/r/24270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Craig Hansen-Sturm > >
