> On Aug. 7, 2014, 6:41 p.m., Jie Yu wrote: > > src/docker/docker.cpp, line 512 > > <https://reviews.apache.org/r/24464/diff/1/?file=654883#file654883line512> > > > > What if 'docker logs' fails? For example, the containerName is not > > valid? How are we gonna detect that?
Right now I'm assuming docker logs shouldn't fail since we did successfully launched the container, as the code does verify as we're keeping docker detached. And if docker logs did fail it should be a docker specific error, that I wonder if I should bail or log. I cannot wait for docker logs to finish since it's running as long as the docker container is running. Not sure what you suggest, but I think minimally I can do a onFailed and log. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review49936 ----------------------------------------------------------- On Aug. 7, 2014, 6:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 6:18 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Redirect docker logs > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
