-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
-----------------------------------------------------------

(Updated Aug. 12, 2014, 6:10 a.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Bugs: MESOS-886
    https://issues.apache.org/jira/browse/MESOS-886


Repository: mesos-git


Description
-------

Added __runTask() to wait for the completion of containerizer->update() and 
check the result before sending RunTaskMessage.


Diffs (updated)
-----

  src/slave/slave.hpp 9d4607e 
  src/slave/slave.cpp 787bd05 
  src/tests/slave_tests.cpp 69be28f 

Diff: https://reviews.apache.org/r/22313/diff/


Testing
-------

SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
SlaveTest.LaunchTaskAfterContainerizerUpdate

./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
--gtest_filter=*LaunchTask*

successful times > 2000

make check


File Attachments
----------------

framework will exit
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
log
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log


Thanks,

Yifan Gu

Reply via email to