----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24515/#review50367 -----------------------------------------------------------
Ship it! src/common/http.cpp <https://reviews.apache.org/r/24515/#comment88127> #include <vector> src/common/http.cpp <https://reviews.apache.org/r/24515/#comment88128> why kill the new line? - Vinod Kone On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24515/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 11:32 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1620 > https://issues.apache.org/jira/browse/MESOS-1620 > > > Repository: mesos-git > > > Description > ------- > > We were not surfacing tasks that are pending validation / authorization. > > These are now surfaced as staging tasks through metrics and through the http > state endpoint. > > > Diffs > ----- > > src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 > src/common/http.hpp 8216401e116406da7557f144ea13756013ec1c09 > src/common/http.cpp d27fe21cd381ed2b6a52b1246bf6c7db33c0873e > src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b > src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 > src/tests/common/http_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/24515/diff/ > > > Testing > ------- > > Added a test for the JSON modeling, there were no tests previously. > > > Thanks, > > Ben Mahler > >