----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/#review50390 -----------------------------------------------------------
Patch looks great! Reviews applied: [24562] All tests passed. - Mesos ReviewBot On Aug. 11, 2014, 7:54 p.m., Ken Sipe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24562/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 7:54 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Consolidated redundant code for zk url parsing. Through that, identified a > test that used zk file for something other than zk. Fixed test, and added > test for file parsing. It is tough to know if something other than zk can be > in the file (assuming it is a zk file). If other things can go into the file > in question, then I can create a file parser. The current URL::Parser lives > in the zookeeper namespace. > > This patch also completes several documented todo is the code. > > > Diffs > ----- > > src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 > src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca > src/tests/master_contender_detector_tests.cpp > fdddfa1a9c793bb406d85d214a18ca4ced53b09f > src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf > > Diff: https://reviews.apache.org/r/24562/diff/ > > > Testing > ------- > > 1 test changed and 1 test added to: master_contender_detector_tests.cpp > MasterContenderDetectorTest > BasicMasterContenderDetectorTest > > all tests pass including styling. > > > Thanks, > > Ken Sipe > >
