----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24635/#review50413 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp <https://reviews.apache.org/r/24635/#comment88183> Is your thought here that rather than do the validation at the master this will just cause the executor to fail (thus the task fail) so the framework will still find out? It's a slightly harder debugging problem, but maybe okay for now. How about a brief comment that explains this reasoning as much, and maybe even a TODO to do some validation in the master? - Benjamin Hindman On Aug. 13, 2014, 5:26 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24635/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 5:26 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp b096b6879e395483fa49aab6abe2c0c9fc8f0216 > src/slave/slave.cpp 787bd05d8c95eac5eaff02c7f31c848a0d873a83 > > Diff: https://reviews.apache.org/r/24635/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
