> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote: > > src/health-check/main.cpp, line 171 > > <https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171> > > > > Thanks for the update! Do you mind adding a test for the shell path? > > Jie Yu wrote: > I think the shell path should have already been tested by the existing > tests, right? > > Timothy Chen wrote: > Yes sorry the new exec path that you have.
Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/#review50405 ----------------------------------------------------------- On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24632/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 5:21 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 > > Diff: https://reviews.apache.org/r/24632/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
