----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/#review50352 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/24177/#comment88054> Remove 'dir' when test finishes? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/24177/#comment88055> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/24177/#comment88056> Ditto. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/24177/#comment88057> Ditto. - Jie Yu On Aug. 1, 2014, 6:06 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24177/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 6:06 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Pass executor directory to Isolator::prepare(). > > Will be used for FilesystemIsolator. > > > Diffs > ----- > > src/slave/containerizer/isolator.hpp > e52e8b15c740c62ef64b49897d3d6ae5179d4719 > src/slave/containerizer/isolator.cpp > 5e61bf2e3cf14be53d41aa657b4a78ab2dd6ecb0 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 780037b093cb5b61254e61ddcfb9ecd4b0551a77 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 3265a8084dfab6f3c9244f8f227e4024d8afe68a > src/slave/containerizer/isolators/cgroups/mem.hpp > 8c476c7847baa923821bc89a1e04f50f019c6ecb > src/slave/containerizer/isolators/cgroups/mem.cpp > e8d1e35a1acdb3beb03a91cfd734a59417657b20 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 4ceb07a6e4f171788cfbabca78c14ae23ff183db > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 > src/slave/containerizer/isolators/posix.hpp > 17bbd10c565aa88048ec3a845014ceee582396d2 > src/slave/containerizer/mesos/containerizer.cpp > 2c394e2c8702166266f5d20ff005abb218da8a6c > src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > > Diff: https://reviews.apache.org/r/24177/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
