----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50494 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/Makefile.am <https://reviews.apache.org/r/24628/#comment88356> How is that we didn't need to include these "src" dirs before but have to know? 3rdparty/libprocess/3rdparty/Makefile.am <https://reviews.apache.org/r/24628/#comment88355> Pull this below #99? Also, should this be inside if WITH_BUNDLED_GMOCK ? 3rdparty/libprocess/3rdparty/gmock_sources.cc.in <https://reviews.apache.org/r/24628/#comment88352> s/is/in/ ? s/automake/Automake/ 3rdparty/libprocess/3rdparty/gmock_sources.cc.in <https://reviews.apache.org/r/24628/#comment88353> s/mundged/munged/ 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/24628/#comment88320> s/#On/# On/ Also, can you expand on the comment? It's not clear to me why you including "stdio.h" here. Is it just a dummy? Also, where is gtest typically located on system installations? - Vinod Kone On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24628/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 2:35 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1171 > https://issues.apache.org/jira/browse/MESOS-1171 > > > Repository: mesos-git > > > Description > ------- > > Enable support to build against unbundled versions of gmock. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 497d038 > 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION > 3rdparty/libprocess/configure.ac 7b39e63 > configure.ac 8fb0a3a > > Diff: https://reviews.apache.org/r/24628/diff/ > > > Testing > ------- > > configure && make check > configure --disable-bundled && make check > configure --with-gmock=/opt/gmock && make check > > > Thanks, > > Timothy St. Clair > >
