----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50518 -----------------------------------------------------------
Ship it! i'm assuming you tested this with all 3 configurations (bundled,system,prefix) like you did for gmock? configure.ac <https://reviews.apache.org/r/23086/#comment88370> shouldn't this be different if we are using bundled "protoc" vs system installed "protoc"? i guess it is ok here because PROTOCOMPILER is only used in non-bundled case below and later in src/Makefile.am. it was definitely a bit confusing to me, so maybe add a comment? alternatively, you could just s/PROTOCOMPILER/PROTOC/ and set it appropriately for bundled/prefix/system cases. i'm assuming you didn't do it that way because it isn't easy to get protobuf version? - Vinod Kone On Aug. 13, 2014, 7:46 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23086/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 7:46 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1174 > https://issues.apache.org/jira/browse/MESOS-1174 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against system installed version of protobuf. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 497d038 > 3rdparty/libprocess/configure.ac 7b39e63 > configure.ac 8fb0a3a > mpi/mpiexec-mesos.in 8812ee2 > src/Makefile.am 0ac95b4 > src/examples/java/test-exception-framework.in 065f3c0 > src/examples/java/test-executor.in 35559d2 > src/examples/java/test-framework.in 9af48f9 > src/examples/java/test-log.in 8afed0d > src/examples/java/test-multiple-executors-framework.in 235eb23 > src/examples/python/test-containerizer.in f71828d > src/examples/python/test-executor.in b22e7a7 > src/examples/python/test-framework.in 64fb1dd > src/python/native/ext_modules.py.in 477e63d > > Diff: https://reviews.apache.org/r/23086/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
