----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24677/#review50532 -----------------------------------------------------------
Ship it! src/docker/docker.cpp <https://reviews.apache.org/r/24677/#comment88395> The image here might come from end user. So for security concern, we should use the argv version to prevent shell injection. You don't need to address that in this patch, but we should address that before releasing. For example, what if image == "&& rm -rf / &&" src/docker/docker.cpp <https://reviews.apache.org/r/24677/#comment88396> Ditto. - Jie Yu On Aug. 13, 2014, 11:32 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24677/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 11:32 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added Docker pull(). BenH already has a patch and I'm taking his and adding > inspect call into pull. > > > Diffs > ----- > > src/docker/docker.hpp 98b2d60 > src/docker/docker.cpp 1cba381 > > Diff: https://reviews.apache.org/r/24677/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >