> On Aug. 13, 2014, 11:07 p.m., Vinod Kone wrote: > > mpi/mpiexec-mesos.in, lines 21-22 > > <https://reviews.apache.org/r/24555/diff/2/?file=659530#file659530line21> > > > > In all these scripts, it's weird to me that we print a failed message > > even if the user specifically asked us to use a non-bundled egg. > > > > More importantly, if a bundled distribute egg exists in the build dir > > (perhaps from an earlier build) we favor it even when the user asked us to > > use the system installed version. > > > > My worry is that issues relating to these would be hard to diagnose > > down the line. > > > > Does this script have access to WITH_BUNDLED_DISTRIBUTE variable? If > > yes we should use that to determine whether to include DISTRIBUTE_EGG in > > the PYTHONPATH (down below where we exec). Does that make sense? > > > > I guess we have the same issue with protobuf egg in the earlier review. > > > > > > Timothy St. Clair wrote: > For the script work I honestly think it needs a lot more work and greater > in scope then just this ticket. > > If it's ok with you, I would like to open some follow up tickets on this. > > > Right now it would be an extremely rare case for folks to reconfigure > bundled/unbundled and build when stale data is around, but I completely agree > the logic is obtuse and weird.
SGTM. Please follow up with appropriate tickets. Thanks Tim. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50522 ----------------------------------------------------------- On Aug. 14, 2014, 3:04 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24555/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 3:04 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1169 > https://issues.apache.org/jira/browse/MESOS-1169 > > > Repository: mesos-git > > > Description > ------- > > Enabling unbundling for distribute python utils. > > > Diffs > ----- > > 3rdparty/Makefile.am 70b45fe > configure.ac 8fb0a3a > mpi/mpiexec-mesos.in 8812ee2 > src/examples/python/test-containerizer.in f71828d > src/examples/python/test-executor.in b22e7a7 > src/examples/python/test-framework.in 64fb1dd > > Diff: https://reviews.apache.org/r/24555/diff/ > > > Testing > ------- > > ./configure && make check > ./configure --disable-bundled && make check > > For prefixed installs require updated PYTHON_PATH. > > > Thanks, > > Timothy St. Clair > >
