> On Aug. 13, 2014, 10:20 p.m., Jie Yu wrote: > > src/docker/docker.cpp, line 266 > > <https://reviews.apache.org/r/24673/diff/1/?file=659614#file659614line266> > > > > I would probably rename it to argv as subprocess's signature uses argv.
Great idea! Thanks Jie! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/#review50519 ----------------------------------------------------------- On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24673/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 9:53 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > > Diff: https://reviews.apache.org/r/24673/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >