> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too?
si_uid represents the user id of the _sending_ process, not the receiving process. Am I missing something? We could log the pid as well, hopefully that helps us identify long-lived proceses, like init or monit. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review50607 ----------------------------------------------------------- On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24700/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 3:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1567 > https://issues.apache.org/jira/browse/MESOS-1567 > > > Repository: mesos-git > > > Description > ------- > > Log the user id when receiving a SIGTERM. This will make debugging more easy. > > > Diffs > ----- > > src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea > > Diff: https://reviews.apache.org/r/24700/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
