> On Aug. 15, 2014, 11:14 p.m., Timothy Chen wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1108-1110 > > <https://reviews.apache.org/r/24730/diff/2/?file=661859#file661859line1108> > > > > It's really just to test out value field explicitly. There are a lot > > more variations but just trying to touch on the common ones. > > Jie Yu wrote: > OK, I guess I missed this part in last patch. So if shell == false, > 'value' will be appended to the docker run according to the code. I was > expecting that 'value' will be ignored and only appending arguments. Maybe > you guys should add some comments to call out this semantics explicitly. > > Timothy Chen wrote: > We plan to add more documentation around DockerInfo once all our work are > in there :) > > Benjamin Hindman wrote: > Yes, definitely Jie! I added more comments to the test, will update the > diff. > > Benjamin Hindman wrote: > Oh wait, this isn't my review! ;-) But I did update Tim's review and > added more commments.
:) How do I get these updates then? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50791 ----------------------------------------------------------- On Aug. 15, 2014, 9:50 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24730/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 9:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Allow override without CommandInfo value to run in command executor > > > Diffs > ----- > > src/launcher/executor.cpp 1aa2c99a5e5b19982e99f03d6fbb3bc3d34cea64 > src/tests/docker_containerizer_tests.cpp > e0fd62f83387635f503817ced7a592cc3ae6e775 > > Diff: https://reviews.apache.org/r/24730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
